fix(selfhost): refresh stale connection tools concurrently and expose EXECUTOR_TOOLS_SYNC_TTL_MS - #1560
Merged
RhysSullivan merged 5 commits intoAug 28, 2026
Conversation
… EXECUTOR_TOOLS_SYNC_TTL_MS
Adityakk9031
force-pushed
the
fix/sync-stale-connection-tools
branch
from
August 10, 2026 12:00
67d03d9 to
5c37b31
Compare
Contributor
Author
|
@RhysSullivan have a look |
Fail at boot on an unparseable or negative EXECUTOR_TOOLS_SYNC_TTL_MS instead of falling back to the default. 0 keeps meaning disabled, now spelled out in the env var's docs and mapped explicitly onto the SDK's null sentinel, since a TTL of 0 means the opposite to the SDK. Type the rebuild list, name the concurrency bound, and add the regression test the concurrency change was missing: a latched MCP fixture that only answers once the whole stale set is in flight, so a serial refresh cannot complete.
…builds The stale-catalog refresh rebuilds several connections at once. Each rebuild ends in a catalog-replacement transaction, and a self-host database is one connection issuing raw BEGIN/COMMIT, so overlapping rebuilds could reopen the transaction collision fixed for same-connection refreshes. Split the phases: upstream discovery stays concurrent at the existing bound, while every catalog write takes a single permit and commits in turn. A rebuild that fails now logs a warning with the connection and the reason, including the cause a plain structural render would drop. The read still succeeds on the stale-but-working catalog and the other rebuilds still finish. Refuse a tools-sync TTL that is not a safe integer, since a larger value silently rounds, and accept the disable tokens in any case. Tests cover the concurrency bound (an extra connection waits while the bound is saturated), non-overlapping persistence observed through real transactions, and a failed rebuild that warns without failing the read.
This was referenced Aug 28, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1519
syncStaleConnectionToolsinpackages/core/sdkto collect connection sync tasks and execute them concurrently viaEffect.all(tasks, { concurrency: 10 })instead of sequentially awaiting them in afor...ofloop.EXECUTOR_TOOLS_SYNC_TTL_MSConfig:HostConfigShapeinpackages/core/apiwithtoolsSyncTtlMsand forwarded it tocreateExecutor.EXECUTOR_TOOLS_SYNC_TTL_MSinapps/host-selfhost/src/config.ts("0","false", or"null"to disable automatic background catalog re-syncing, or a custom interval in ms).toolsSyncTtlMsinSelfHostHostConfigand added unit tests inapps/host-selfhost/src/executor-config.test.ts.